Does anyone know what the best offer I can get for an s5 at the minute on contract?

I colleague has just upgraded to the s5 on EE and this is what she told me she gets

Free s5
Unlimited calls
Unlimited texts
2g 4g
£25 android play voucher
24 months
£39 per month

This seems a pretty good deal.

Yet when I phone orange/EE to upgrade I get told ive to pay for the phone (£59) unlimited calls/txts and 1g 4g and I have to pay £45 per month.

The deal you're being quoted doesn't even match what EE have on their website - they're offering Unl/Unl/2GB for £44.99/month and £19.99 up-front.
Or, even better, Unl/Unl/4GB (double speed) for £42.99/month and £19.99 up-front.
If you want more data, there's Unl/Unl/10GB (double speed) for £47.99/month and £19.99 up-front - though I'd been told that EE stores were offering the handset free, with a Gear Fit included, on that tariff.

Did your colleague upgrade directly or through a third-party?
Or, did they upgrade in-store? Because store managers can sometimes play a little bit with discounts, especially on upgrades, not to mention trade-in old phones to offset up-front costs.

I got an S5 last week on 3.

AYCE data, texts and minutes for £40 a month. No upfront handset fee either, although I chose to upgrade early so paid an early upgrade fee.