I felt the death was played superbly well overall.
It seems only natural that even in a TV show, you'd have sympathy for the death of a person who tried to do right. No matter how surefire, or cocky or complacent someone is you'd have to really have a deep disliking for them not to feel a shred of sympathy. I feel the scenes leading up to her death were played out just as they should have been - even then they stuck to their guns with Clara's personality. She accepted even when death was inevitable that it was her own fault, and she spent her final moments trying to console the Doctor (and to a lesser extent Rigsy). No concern for herself, no regard for her own wellbeing, and that plays exactly as it has done for her throughout the series. That she stuck by that to the very end, and it is ultimately a heroic trait that she tried to make the Doctor feel better before she went, is why it was a great ending that warranted sympathy.
The nature of the death is also exactly what the show needed. It showed that it isn't always the big threats like the Daleks or the Weeping Angels that will kill you. Sometimes it's the passing threat with a vague description, lurking in a dark alley that will get you. Clara fell at what is essentially the last hurdle of the series, and it worked brilliantly. As someone who loves the character I still couldn't see many feasible alternate exits for her. Whilst I don't quite think she had a deathwish, she nonetheless valued life a lot less as a result of her losses - she's lost her Mum, she's lost Danny, she went through a fairly traumatic time of losing Eleven... she savours every moment of life she gets with the Doctor, but in many ways I feel she just became reckless as a result of her also becoming desensitised to death - something we've seen as true since near the end of Series 8.